Make the markdownlint gate pass now that the action is allowed - #10636
Merged
Conversation
Allowing DavidAnson/markdownlint-cli2-action in the organization allowed-actions list lets the workflow start again after 435 consecutive startup_failure runs. It now creates a job and immediately fails with 278 issues in 7 files. 273 of those are MD060/table-column-style, cosmetic pipe padding added in markdownlint v0.41 that no table in the repository follows. Disable it next to the existing MD013 opt-out rather than reformatting 273 table cells across 6 RFCs. Fix the 5 genuine violations: MD004, MD022, MD032, MD038, and an MD051 link fragment pointing at a heading that does not exist. 🤖
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Markdown lint configuration and resolves newly surfaced violations so the restored gate passes.
Changes:
- Disables cosmetic
MD060table-padding enforcement. - Fixes heading spacing, list formatting, inline-code spacing, and a broken anchor.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.markdownlint-cli2.jsonc |
Disables MD060. |
docs/RFCs/016-JUnit-Report.md |
Fixes MD038. |
docs/RFCs/017-TestHost-Launcher.md |
Fixes heading spacing. |
docs/RFCs/020-Resource-Lock-Attribute.md |
Corrects the heading link fragment. |
docs/RFCs/021-Per-Test-Temporary-Directory.md |
Fixes list formatting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Expert Review Summary — Docs & Lint Config Only
| Dimension | Verdict |
|---|---|
| Correctness | ✅ Pass |
| Documentation | ✅ Pass |
| Style / Formatting | ✅ Pass |
Findings
No issues found. This is a low-risk, docs-only change. Verified highlights:
- RFC 020 anchor fix (
#granularity-guidance→#guidance-granularity): Confirmed correct. The target heading is## Guidance (granularity), which GitHub renders as#guidance-granularity. The old link was broken. - MD060 disable: Reasonable — the rule (cosmetic table-pipe padding) was added in markdownlint v0.41 and no existing table conforms. Disabling avoids mass churn.
- RFC 016 wording (
`: `→ "colon-space separator"): Improves readability; avoids inline code that could confuse markdown renderers in some contexts. - RFC 017 blank line after heading: Fixes MD022 (headings should be surrounded by blank lines).
- RFC 021 line rewrap: Pure formatting; no semantic change.
Verdict: LGTM — no blocking issues.
Azat Mukhametshin (azat-msft)
approved these changes
Aug 18, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The markdownlint gate ran for the first time since 2026-07-25 today, because
DavidAnson/markdownlint-cli2-actionis now permitted by the organization allowed-actions list. It starts, creates a job, and fails: 278 issues in 7 files. This makes it pass.Why it was dead
The workflow ended in
startup_failureon 435 consecutive runs. No job is created, so there is no check run andruns/<id>/logsreturns 404 — the failure was invisible everywhere except the run page itself, which is why it went unnoticed for three weeks. The error, verbatim from run 31674560655:The allow-list permitted the literal tag
@v18and nothing else. That matches the history exactly: #10163 bumped v18 to v24 and broke it, #10196 reverted to v18 as a side effect of an unrelated MSBuildCache change and it worked again, and #10214 re-bumped to v24.1.0 and broke it for good.That cause is fixed outside this repository, so
.github/workflows/markdownlint.ymlis unchanged here and no Dependabot ignore is needed.What this changes
Enabling the gate exposes 278 issues, 273 of them
MD060/table-column-style— cosmetic pipe padding added in markdownlint v0.41 that no table in the repository follows. It is disabled in.markdownlint-cli2.jsoncnext to the existingMD013opt-out rather than reformatting 273 table cells across 6 RFCs. One or the other, not both.The 5 genuine violations are fixed:
MD004,MD022,MD032,MD038, and anMD051link fragment that pointed at#granularity-guidancewhen the heading is## Guidance (granularity).Verified:
markdownlint-cli2@0.23.2reports 0 issues across 86 files, the same file count as before, andpython .github/scripts/check_action_pins.pyexits 0 across 2272 references.🤖